Using devm_ioremap simplify code.

Signed-off-by: Corentin Labbe <cla...@baylibre.com>
---
 drivers/staging/media/zoran/zoran_card.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/media/zoran/zoran_card.c 
b/drivers/staging/media/zoran/zoran_card.c
index ed4ecf92c040..36305aaabd7d 100644
--- a/drivers/staging/media/zoran/zoran_card.c
+++ b/drivers/staging/media/zoran/zoran_card.c
@@ -1003,7 +1003,6 @@ static void zoran_remove(struct pci_dev *pdev)
        pci_free_irq(zr->pci_dev, 0, zr);
        /* unmap and free memory */
        dma_free_coherent(&zr->pci_dev->dev, BUZ_NUM_STAT_COM * sizeof(u32), 
zr->stat_com, zr->p_sc);
-       iounmap(zr->zr36057_mem);
        pci_release_regions(pdev);
        pci_disable_device(zr->pci_dev);
        video_unregister_device(zr->video_dev);
@@ -1156,7 +1155,7 @@ static int zoran_probe(struct pci_dev *pdev, const struct 
pci_device_id *ent)
        if (err)
                goto zr_unreg;
 
-       zr->zr36057_mem = pci_ioremap_bar(zr->pci_dev, 0);
+       zr->zr36057_mem = devm_ioremap(&pdev->dev, pci_resource_start(pdev, 0), 
pci_resource_len(pdev, 0));
        if (!zr->zr36057_mem) {
                pci_err(pdev, "%s() - ioremap failed\n", __func__);
                goto zr_pci_release;
@@ -1172,7 +1171,7 @@ static int zoran_probe(struct pci_dev *pdev, const struct 
pci_device_id *ent)
                } else {
                        pci_err(pdev, "%s - cannot assign IRQ, error code 
%d\n", __func__, result);
                }
-               goto zr_unmap;
+               goto zr_pci_release;
        }
 
        /* set PCI latency timer */
@@ -1273,8 +1272,6 @@ static int zoran_probe(struct pci_dev *pdev, const struct 
pci_device_id *ent)
 zr_free_irq:
        btwrite(0, ZR36057_SPGPPCR);
        pci_free_irq(zr->pci_dev, 0, zr);
-zr_unmap:
-       iounmap(zr->zr36057_mem);
 zr_pci_release:
        pci_release_regions(pdev);
 zr_unreg:
-- 
2.26.2

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to