On Thu, Nov 19, 2020 at 07:05:22AM +0100, Sergio Paracuellos wrote: > > > +static inline void phy_write(struct mt7621_pci_phy *phy, u32 val, u32 > > > reg) > > > +{ > > > + regmap_write(phy->regmap, reg, val); > > > > Why not use regmap_ calls directly and avoid the dummy wrappers..? > > This is because name was the dummy names are a bit shorter :) but if > it is also necessary I will use directly regmap_ functions.
At least don't swap the last two arguments around. regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel