On Sat, Dec 26, 2020 at 04:02:56PM +0800, Dinghao Liu wrote: > There is an allocation for priv->rx_urb[16] has no null check, > which may lead to a null pointer dereference. > > Signed-off-by: Dinghao Liu <dinghao....@zju.edu.cn> > --- > drivers/staging/rtl8192u/r8192U_core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c > b/drivers/staging/rtl8192u/r8192U_core.c > index 93676af98629..9fc4adc83d77 100644 > --- a/drivers/staging/rtl8192u/r8192U_core.c > +++ b/drivers/staging/rtl8192u/r8192U_core.c > @@ -1608,6 +1608,8 @@ static short rtl8192_usb_initendpoints(struct > net_device *dev) > void *oldaddr, *newaddr; > > priv->rx_urb[16] = usb_alloc_urb(0, GFP_KERNEL); > + if (!priv->rx_urb[16]) > + return -ENOMEM; > priv->oldaddr = kmalloc(16, GFP_KERNEL); > if (!priv->oldaddr) > return -ENOMEM;
There is a bug here, where the memory is not freed from the alloc urb call, right? Anyway, something to fix up in a leter patch, thanks. greg k-h _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
