use __func__ macro instead of literal function name in RT_TRACE() in
 * phy_set_rf8256_bandwidth()
 * phy_rf8256_config_para_file()

remove unnecessary return at the end of phy_set_rf8256_ofdm_tx_power()

these coding style issues are flagged as warnings by scripts/checkpatch.pl.


Signed-off-by: Du Cheng <duche...@gmail.com>
---
changes v2:
* improve description and subject

changes v1:
* fix coding style

 drivers/staging/rtl8192u/r8190_rtl8256.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c 
b/drivers/staging/rtl8192u/r8190_rtl8256.c
index fee3bfb99075..54747fda552f 100644
--- a/drivers/staging/rtl8192u/r8190_rtl8256.c
+++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
@@ -73,11 +73,11 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, enum 
ht_channel_width Band
                                        else
                                                rtl8192_phy_SetRFReg(dev, (enum 
rf90_radio_path_e)eRFPath, 0x14, bMask12Bits, 0x5ab);
                                } else {
-                                       RT_TRACE(COMP_ERR, 
"phy_set_rf8256_bandwidth(): unknown hardware version\n");
+                                       RT_TRACE(COMP_ERR, "%s(): unknown 
hardware version\n", __func__);
                                        }
                                break;
                default:
-                               RT_TRACE(COMP_ERR, "phy_set_rf8256_bandwidth(): 
unknown Bandwidth: %#X\n", Bandwidth);
+                               RT_TRACE(COMP_ERR, "%s(): unknown Bandwidth: 
%#X\n", __func__, Bandwidth);
                                break;
                }
        }
@@ -213,7 +213,7 @@ static void phy_rf8256_config_para_file(struct net_device 
*dev)
                }
 
                if (ret) {
-                       RT_TRACE(COMP_ERR, 
"phy_rf8256_config_para_file():Radio[%d] Fail!!", eRFPath);
+                       RT_TRACE(COMP_ERR, "%s():Radio[%d] Fail!!", __func__, 
eRFPath);
                        goto phy_RF8256_Config_ParaFile_Fail;
                }
        }
@@ -291,5 +291,4 @@ void phy_set_rf8256_ofdm_tx_power(struct net_device *dev, 
u8 powerlevel)
                }
                rtl8192_setBBreg(dev, RegOffset[index], 0x7f7f7f7f, writeVal);
        }
-       return;
 }
-- 
2.27.0

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to