On Thu, Feb 18, 2021 at 02:21:54PM +0500, Muhammad Usama Anjum wrote:
> It is wrong to change the endianness of a variable which has just one
> byte size.
>
> Sparse warnings fixed:
> drivers/staging//wimax/i2400m/control.c:452:17: warning: cast to restricted
> __le32
> drivers/staging//wimax/i2400m/control.c:452:17: warning: cast to restricted
> __le32
> drivers/staging//wimax/i2400m/op-rfkill.c:159:14: warning: cast to restricted
> __le32
> drivers/staging//wimax/i2400m/op-rfkill.c:160:14: warning: cast to restricted
> __le32
>
> Signed-off-by: Muhammad Usama Anjum <musamaan...@gmail.com>
> ---
> drivers/staging/wimax/i2400m/control.c | 4 ++--
> drivers/staging/wimax/i2400m/op-rfkill.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/wimax/i2400m/control.c
> b/drivers/staging/wimax/i2400m/control.c
> index 1e270b2101e8..b6b2788af162 100644
> --- a/drivers/staging/wimax/i2400m/control.c
> +++ b/drivers/staging/wimax/i2400m/control.c
> @@ -452,8 +452,8 @@ void i2400m_report_state_parse_tlv(struct i2400m *i2400m,
> d_printf(2, dev, "%s: RF status TLV "
> "found (0x%04x), sw 0x%02x hw 0x%02x\n",
> tag, I2400M_TLV_RF_STATUS,
> - le32_to_cpu(rfss->sw_rf_switch),
> - le32_to_cpu(rfss->hw_rf_switch));
> + rfss->sw_rf_switch,
> + rfss->hw_rf_switch);
What do you mean by "one byte"? This is a le32 sized variable, right?
If not, why isn't the le32_to_cpu() call complaining?
> i2400m_report_tlv_rf_switches_status(i2400m, rfss);
> }
> if (0 == i2400m_tlv_match(tlv, I2400M_TLV_MEDIA_STATUS, sizeof(*ms))) {
> diff --git a/drivers/staging/wimax/i2400m/op-rfkill.c
> b/drivers/staging/wimax/i2400m/op-rfkill.c
> index fbddf2e18c14..a159808f0ec2 100644
> --- a/drivers/staging/wimax/i2400m/op-rfkill.c
> +++ b/drivers/staging/wimax/i2400m/op-rfkill.c
> @@ -156,8 +156,8 @@ void i2400m_report_tlv_rf_switches_status(
> enum i2400m_rf_switch_status hw, sw;
> enum wimax_st wimax_state;
>
> - sw = le32_to_cpu(rfss->sw_rf_switch);
> - hw = le32_to_cpu(rfss->hw_rf_switch);
> + sw = rfss->sw_rf_switch;
> + hw = rfss->hw_rf_switch;
Same here.
thanks,
greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
