On Thu, Mar 18, 2021 at 10:14:15AM +0100, Fabio Aiuto wrote:
> Hi,
>
> some suggestions before diving in a new task.
> The following checkpatch issue:
>
> --
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> #559: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:559:
> + DBG_871X("%s\n", __func__);
>
> simply says to remove the line, due to the existence of the more
> appealing ftrace facility, right?
>
> @@ -556,8 +554,6 @@ void update_sta_info_apmode(struct adapter *padapter,
> struct sta_info *psta)
> /* set intf_tag to if1 */
> /* psta->intf_tag = 0; */
>
> - DBG_871X("%s\n", __func__);
> -
> /* psta->mac_id = psta->aid+4; */
> /* psta->mac_id = psta->aid+1;//alloc macid when call
> rtw_alloc_stainfo(), */
> /* release macid when call rtw_free_stainfo() */
>
Yes, stuff like this can be deleted.
thanks,
greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
