Hi ratnesh-r1, Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/ratnesh-r1/staging-android-ashmem-Declared-file-operation-with-const-keyword/20220124-151116 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git fa783154524a71ab74e293cd8251155e5971952b config: x86_64-randconfig-a002-20220124 (https://download.01.org/0day-ci/archive/20220124/202201241907.69jg769l-...@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/c24fe2afe4abdf6436628abd13a0109ec420f373 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review ratnesh-r1/staging-android-ashmem-Declared-file-operation-with-const-keyword/20220124-151116 git checkout c24fe2afe4abdf6436628abd13a0109ec420f373 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/staging/android/ashmem.c: In function 'ashmem_mmap': >> drivers/staging/android/ashmem.c:431:16: error: assignment of read-only >> variable 'vmfile_fops' 431 | vmfile_fops = *vmfile->f_op; | ^ >> drivers/staging/android/ashmem.c:432:21: error: assignment of member 'mmap' >> in read-only object 432 | vmfile_fops.mmap = ashmem_vmfile_mmap; | ^ >> drivers/staging/android/ashmem.c:433:34: error: assignment of member >> 'get_unmapped_area' in read-only object 433 | vmfile_fops.get_unmapped_area = | ^ vim +/vmfile_fops +431 drivers/staging/android/ashmem.c 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 377 11980c2ac4ccfa Robert Love 2011-12-20 378 static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) 11980c2ac4ccfa Robert Love 2011-12-20 379 { c24fe2afe4abdf ratnesh-r1 2022-01-23 380 static const struct file_operations vmfile_fops; 11980c2ac4ccfa Robert Love 2011-12-20 381 struct ashmem_area *asma = file->private_data; 11980c2ac4ccfa Robert Love 2011-12-20 382 int ret = 0; 11980c2ac4ccfa Robert Love 2011-12-20 383 11980c2ac4ccfa Robert Love 2011-12-20 384 mutex_lock(&ashmem_mutex); 11980c2ac4ccfa Robert Love 2011-12-20 385 11980c2ac4ccfa Robert Love 2011-12-20 386 /* user needs to SET_SIZE before mapping */ 59848d6aded59a Alistair Strachan 2018-06-19 387 if (!asma->size) { 11980c2ac4ccfa Robert Love 2011-12-20 388 ret = -EINVAL; 11980c2ac4ccfa Robert Love 2011-12-20 389 goto out; 11980c2ac4ccfa Robert Love 2011-12-20 390 } 11980c2ac4ccfa Robert Love 2011-12-20 391 8632c614565d0c Alistair Strachan 2018-06-19 392 /* requested mapping size larger than object size */ 8632c614565d0c Alistair Strachan 2018-06-19 393 if (vma->vm_end - vma->vm_start > PAGE_ALIGN(asma->size)) { 11980c2ac4ccfa Robert Love 2011-12-20 394 ret = -EINVAL; 11980c2ac4ccfa Robert Love 2011-12-20 395 goto out; 11980c2ac4ccfa Robert Love 2011-12-20 396 } 11980c2ac4ccfa Robert Love 2011-12-20 397 11980c2ac4ccfa Robert Love 2011-12-20 398 /* requested protection bits must match our allowed protection mask */ 59848d6aded59a Alistair Strachan 2018-06-19 399 if ((vma->vm_flags & ~calc_vm_prot_bits(asma->prot_mask, 0)) & 59848d6aded59a Alistair Strachan 2018-06-19 400 calc_vm_prot_bits(PROT_MASK, 0)) { 11980c2ac4ccfa Robert Love 2011-12-20 401 ret = -EPERM; 11980c2ac4ccfa Robert Love 2011-12-20 402 goto out; 11980c2ac4ccfa Robert Love 2011-12-20 403 } 56f76fc68492af Arve Hjønnevåg 2011-12-20 404 vma->vm_flags &= ~calc_vm_may_flags(~asma->prot_mask); 11980c2ac4ccfa Robert Love 2011-12-20 405 11980c2ac4ccfa Robert Love 2011-12-20 406 if (!asma->file) { 11980c2ac4ccfa Robert Love 2011-12-20 407 char *name = ASHMEM_NAME_DEF; 11980c2ac4ccfa Robert Love 2011-12-20 408 struct file *vmfile; 3e338d3c95c735 Suren Baghdasaryan 2020-07-30 409 struct inode *inode; 11980c2ac4ccfa Robert Love 2011-12-20 410 11980c2ac4ccfa Robert Love 2011-12-20 411 if (asma->name[ASHMEM_NAME_PREFIX_LEN] != '\0') 11980c2ac4ccfa Robert Love 2011-12-20 412 name = asma->name; 11980c2ac4ccfa Robert Love 2011-12-20 413 11980c2ac4ccfa Robert Love 2011-12-20 414 /* ... and allocate the backing shmem file */ 11980c2ac4ccfa Robert Love 2011-12-20 415 vmfile = shmem_file_setup(name, asma->size, vma->vm_flags); 7f44cb0ba88b40 Viresh Kumar 2015-07-31 416 if (IS_ERR(vmfile)) { 11980c2ac4ccfa Robert Love 2011-12-20 417 ret = PTR_ERR(vmfile); 11980c2ac4ccfa Robert Love 2011-12-20 418 goto out; 11980c2ac4ccfa Robert Love 2011-12-20 419 } 97fbfef6bd5978 Shuxiao Zhang 2017-04-06 420 vmfile->f_mode |= FMODE_LSEEK; 3e338d3c95c735 Suren Baghdasaryan 2020-07-30 421 inode = file_inode(vmfile); 3e338d3c95c735 Suren Baghdasaryan 2020-07-30 422 lockdep_set_class(&inode->i_rwsem, &backing_shmem_inode_class); 11980c2ac4ccfa Robert Love 2011-12-20 423 asma->file = vmfile; 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 424 /* 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 425 * override mmap operation of the vmfile so that it can't be 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 426 * remapped which would lead to creation of a new vma with no 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 427 * asma permission checks. Have to override get_unmapped_area 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 428 * as well to prevent VM_BUG_ON check for f_ops modification. 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 429 */ 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 430 if (!vmfile_fops.mmap) { 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 @431 vmfile_fops = *vmfile->f_op; 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 @432 vmfile_fops.mmap = ashmem_vmfile_mmap; 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 @433 vmfile_fops.get_unmapped_area = 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 434 ashmem_vmfile_get_unmapped_area; 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 435 } 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 436 vmfile->f_op = &vmfile_fops; 11980c2ac4ccfa Robert Love 2011-12-20 437 } 11980c2ac4ccfa Robert Love 2011-12-20 438 get_file(asma->file); 11980c2ac4ccfa Robert Love 2011-12-20 439 11980c2ac4ccfa Robert Love 2011-12-20 440 /* 11980c2ac4ccfa Robert Love 2011-12-20 441 * XXX - Reworked to use shmem_zero_setup() instead of 11980c2ac4ccfa Robert Love 2011-12-20 442 * shmem_set_file while we're in staging. -jstultz 11980c2ac4ccfa Robert Love 2011-12-20 443 */ 11980c2ac4ccfa Robert Love 2011-12-20 444 if (vma->vm_flags & VM_SHARED) { 11980c2ac4ccfa Robert Love 2011-12-20 445 ret = shmem_zero_setup(vma); 11980c2ac4ccfa Robert Love 2011-12-20 446 if (ret) { 11980c2ac4ccfa Robert Love 2011-12-20 447 fput(asma->file); 11980c2ac4ccfa Robert Love 2011-12-20 448 goto out; 11980c2ac4ccfa Robert Love 2011-12-20 449 } 44960f2a7b63e2 John Stultz 2018-07-31 450 } else { 44960f2a7b63e2 John Stultz 2018-07-31 451 vma_set_anonymous(vma); 11980c2ac4ccfa Robert Love 2011-12-20 452 } 11980c2ac4ccfa Robert Love 2011-12-20 453 295992fb815e79 Christian König 2020-09-14 454 vma_set_file(vma, asma->file); 295992fb815e79 Christian König 2020-09-14 455 /* XXX: merge this with the get_file() above if possible */ 295992fb815e79 Christian König 2020-09-14 456 fput(asma->file); 11980c2ac4ccfa Robert Love 2011-12-20 457 11980c2ac4ccfa Robert Love 2011-12-20 458 out: 11980c2ac4ccfa Robert Love 2011-12-20 459 mutex_unlock(&ashmem_mutex); 11980c2ac4ccfa Robert Love 2011-12-20 460 return ret; 11980c2ac4ccfa Robert Love 2011-12-20 461 } 11980c2ac4ccfa Robert Love 2011-12-20 462 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
