Hi Davidlohr! Don't worry. I am not discouraged. :)
I understand your concern that the patch feels superficial. It's what the task asked us to do. I suspect the author(s) of the Eudyptula Challenge designed this task to get us involved with the Linux kernel community. I have been looking for a bug in 'usbip' to bundle with my patch. The only bug that I could find (as of 16-Jun-2014) on bugzilla.kernel.org related to 'usbip' is Bug 77191. Bug 77191 - ftdi-sio (usbserial) over usbip hung after disconnect while in use (https://bugzilla.kernel.org/show_bug.cgi?id=77191) Sadly the bug doesn't seem to be newbie friendly as it requires special setup to reproduce and requires the developer to know about the intricacies of the 'usbip' subsystem. I understand that people commiting their specialized knowledge is how the kernel development actually works. But USB is not my speciality (yet). Could you point me to more beginner friendly bugs which aren't superficial code cleanups? Can I bundle fixes to subsystems other than 'usbip' with the code cleanup patch for 'usbip'? Regards, Wahib On Fri, Jun 13, 2014 at 12:25 AM, Davidlohr Bueso <davidl...@hp.com> wrote: > On Thu, 2014-06-12 at 23:40 +0400, Wahib Faizi wrote: >> Fix coding style issues detected by checkpatch.pl in usbip_host_driver.c. > > Sorry but unless bundled with something more meaningful, I really don't > see the value in these changes. I certainly don't want to discourage > folks or anything, but just testing other patches is a lot more helpful > than this. > > I haven't followed much about the Eudyptula Challenge, but I hope other > assignments are more involved than this. > > Thanks, > Davidlohr > _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
