On Tue, Jun 24, 2014 at 10:06 AM, Russell King - ARM Linux <li...@arm.linux.org.uk> wrote: > Denis, > > This patch creates binding documentation. Any patch which does so > should be copied to the DT people so they can review the bindings > and give appropriate acks. It would be better if you separate the > binding documentation updates from the other functional changes too. > > I've added them on this reply to see whether they'll feel friendly > enough to comment on the patch as it stands to avoid having to go > through two more rounds on this already-fourteen revision patch set. > > On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: >> Signed-off-by: Denis Carikli <de...@eukrea.com> >> --- >> ChangeLog v13->v14: >> - None >> >> ChangeLog v12->v13: >> - Added a note explaining why the size is zero in >> the eukrea_mbimxsd51_dvi(s)vga structs. >> ChangeLog v11->v12: >> - Rebased: It now uses the new DRM_MODE_FLAG_POL_DE flags defines names >> >> ChangeLog v10->v11: >> - New patch. >> --- >> .../bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt | 7 ++ >> .../bindings/panel/eukrea,mbimxsd51-dvi-svga.txt | 7 ++ >> .../bindings/panel/eukrea,mbimxsd51-dvi-vga.txt | 7 ++ >> drivers/gpu/drm/panel/panel-simple.c | 83 >> ++++++++++++++++++++ >> 4 files changed, 104 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt >> create mode 100644 >> Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt >> create mode 100644 >> Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt >> >> diff --git >> a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt >> b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt >> new file mode 100644 >> index 0000000..03679d0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt >> @@ -0,0 +1,7 @@ >> +Eukrea CMO-QVGA (320x240 pixels) TFT LCD panel >> + >> +Required properties: >> +- compatible: should be "eukrea,mbimxsd51-cmo-qvga" >> + >> +This binding is compatible with the simple-panel binding, which is specified >> +in simple-panel.txt in this directory. >> diff --git >> a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt >> b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt >> new file mode 100644 >> index 0000000..f408c9a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt >> @@ -0,0 +1,7 @@ >> +Eukrea DVI-SVGA (800x600 pixels) DVI output. >> + >> +Required properties: >> +- compatible: should be "eukrea,mbimxsd51-dvi-svga" >> + >> +This binding is compatible with the simple-panel binding, which is specified >> +in simple-panel.txt in this directory. >> diff --git >> a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt >> b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt >> new file mode 100644 >> index 0000000..8ea90da >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt >> @@ -0,0 +1,7 @@ >> +Eukrea DVI-VGA (640x480 pixels) DVI output. >> + >> +Required properties: >> +- compatible: should be "eukrea,mbimxsd51-dvi-vga" >> + >> +This binding is compatible with the simple-panel binding, which is specified >> +in simple-panel.txt in this directory.
Seems like we could just have a list of compatible strings rather than a mostly duplicated file. >> diff --git a/drivers/gpu/drm/panel/panel-simple.c >> b/drivers/gpu/drm/panel/panel-simple.c >> index a251361..adc40a7 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -403,6 +403,80 @@ static const struct panel_desc edt_etm0700g0dh6 = { >> }, >> }; >> >> +static const struct drm_display_mode eukrea_mbimxsd51_cmoqvga_mode = { >> + .clock = 6500, >> + .hdisplay = 320, >> + .hsync_start = 320 + 38, >> + .hsync_end = 320 + 38 + 20, >> + .htotal = 320 + 38 + 20 + 30, >> + .vdisplay = 240, >> + .vsync_start = 240 + 15, >> + .vsync_end = 240 + 15 + 4, >> + .vtotal = 240 + 15 + 4 + 3, >> + .vrefresh = 60, >> + .pol_flags = DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE | >> + DRM_MODE_FLAG_POL_DE_LOW, Why aren't you using: Documentation/devicetree/bindings/video/display-timing.txt Rob _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel