On 2014-07-31 21:28, Hartley Sweeten wrote:
On Thursday, July 31, 2014 6:48 AM, Ian Abbott wrote:
The "amplc_pci224" driver retains a "legacy" attach mechanism via the
`COMEDI_DEVCONFIG` ioctl and the comedi driver "attach" hook, but
usually attaches PCI devices automatically via the comedi driver's
"auto_attach" hook. The legacy mechanism is only retained so that
options can be passed via the ioctl to indicate how some hardware
jumpers are set on the boards, which is used to set up the range tables.
That's no use if the PCI device is attached automatically as the range
tables will be set up according to the factory default jumper positions.
Change the range tables to include all possible ranges, regardless of
jumper positions. Then there is no need to have options to control
setting up the range tables and the "legacy" attach mechanism can be
removed.
Also, tidy the code up a bit.
Looks good.
Reviewed-by: H Hartley Sweeten <hswee...@visionengravers.com>
Side note:
Now that the manual attach has been removed, you could also remove
the board information from the comedi_driver declaration.
Good point. I can do that as a follow-up patch. It only affects the
output of /proc/comedi I think.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
