On Tue, Sep 23, 2014 at 09:22:08AM +0900, Daeseok Youn wrote: > Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> > --- > drivers/staging/dgap/dgap.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c > index 779d144..637ea8a 100644 > --- a/drivers/staging/dgap/dgap.c > +++ b/drivers/staging/dgap/dgap.c > @@ -1026,6 +1026,7 @@ static void dgap_release_remap(struct board_t *brd) > release_mem_region(brd->membase, 0x200000); > release_mem_region(brd->membase + PCI_IO_OFFSET, 0x200000); > iounmap(brd->re_map_membase); > + iounmap(brd->re_map_port);
I don't think it matters, but at least aesthetically it would be better to unmap first and then release the regions. (You can do this in a different patch). regards, dan carpenter _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
