Or we could fix it but add a multi-line comment with lots of capital
letters and exclamation marks.  I guess we would need to make a function
since this cast is in several places.

void *silence_buggy_casting(u32 pointer)
{
        /*
         * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGER!
         * FIXME!!!  We know this cast is totally buggy.  The BCM driver
         * doesn't work on 64 bits.  But no one knows how to make this
         * work.  Oh well.  Let's silence the GCC warning.
         * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGER!
         *
         */
        return (void *)(long)pointer;
}

Something really ugly and gnarly like that would be hard to ignore.

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to