Dan Carpenter <dan.carpen...@oracle.com> writes:
> On Mon, Nov 10, 2014 at 06:11:39PM -0500, jes.soren...@redhat.com wrote:
>> diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c
>> b/drivers/staging/rtl8723au/core/rtw_xmit.c
>> index 18a9f34..f8b1243 100644
>> --- a/drivers/staging/rtl8723au/core/rtw_xmit.c
>> +++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
>> @@ -1247,7 +1247,7 @@ s32 rtw_put_snap23a(u8 *data, u16 h_proto)
>>              ether_addr_copy(data, rfc1042_header);
>
> Doesn't the ether_add_copy() also require that data is aligned?
>
> regards,
> dan carpenter

Hi Dan,

Actually I think the other one was a false positive, and wasn't
necessary either. We're putting the data onto an xmit frame allocated
within the driver, so alignment ought to be safe.

Cheers,
Jes
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to