First of all, these patches are *so* much better.  Thank you very much!

On Fri, Dec 05, 2014 at 05:09:16PM -0500, Benjamin Romer wrote:
> Fix the declaration so it is a single line. Fix CamelCase parameter
> names:
> 
> MajorDev => major_dev

In the original code there were two variables.
MajorDev (global) and majorDev (local), this patch changes majorDev and
not MajorDev as the changelog says.

Don't resend, this is not worth worrying about, it just amused me.

> pControlVm_channel => controlvm_channel
> 
> Remove the unnecessary gotos and just return directly in error cases.
> Fix the last error condition so it returns the result of cdev_add()
> instead of always zero.

Actually it doesn't, it returns -1 if cdev_add() fails... But the
thought was good.  Anyway, you can patch this stuff up in later patches.
Maybe you already do.  :)

Good job people, these are looking nice.  I like the _cmp() == 0 changes
and removing gotos and the other cleanups.  All these are looking good.

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to