On Wed, Dec 10, 2014 at 03:39:09PM -0800, Joe Perches wrote:
> On Wed, 2014-12-10 at 22:33 +0000, Luis de Bethencourt wrote:
> > checkpatch makes an exception to the 80-colum rule for quotes strings, and
> > Documentation/CodingStyle recommends not splitting quotes strings across
> > lines
> > because it breaks the ability to grep for the string. Fixing these.
> []
> > diff --git a/drivers/staging/media/lirc/lirc_zilog.c
> > b/drivers/staging/media/lirc/lirc_zilog.c
> []
> > @@ -794,9 +796,9 @@ static int fw_load(struct IR_tx *tx)
> > if (!read_uint8(&data, tx_data->endp, &version))
> > goto corrupt;
> > if (version != 1) {
> > - dev_err(tx->ir->l.dev, "unsupported code set file version (%u,
> > expected"
> > - "1) -- please upgrade to a newer driver",
> > - version);
> > + dev_err(tx->ir->l.dev,
> > + "unsupported code set file version (%u, expected 1) --
> > please upgrade to a newer driver",
> > + version);
>
> Unrelated but this one should have a '\n' termination
> at the end of the format.
>
I can add that change, no problem. As part of this patch or a third one?
Thanks for reviewing,
Luis
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
