There is otherwise a risk of a possible null pointer dereference.

Was largely found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
---
 drivers/staging/lustre/lustre/osc/lproc_osc.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c 
b/drivers/staging/lustre/lustre/osc/lproc_osc.c
index 9f719bc..9ba6293 100644
--- a/drivers/staging/lustre/lustre/osc/lproc_osc.c
+++ b/drivers/staging/lustre/lustre/osc/lproc_osc.c
@@ -237,13 +237,15 @@ static ssize_t osc_cur_grant_bytes_seq_write(struct file 
*file, const char *buff
                                  size_t count, loff_t *off)
 {
        struct obd_device *obd = ((struct seq_file 
*)file->private_data)->private;
-       struct client_obd *cli = &obd->u.cli;
+       struct client_obd *cli;
        int             rc;
        __u64         val;
 
        if (obd == NULL)
                return 0;
 
+       cli = &obd->u.cli;
+
        rc = lprocfs_write_u64_helper(buffer, count, &val);
        if (rc)
                return rc;
-- 
1.7.10.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to