drivers/staging/fpga/socfpga.c:647:5-11: inconsistent IS_ERR and PTR_ERR, 
PTR_ERR on line 648

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Alan Tull <at...@opensource.altera.com>
Signed-off-by: Fengguang Wu <fengguang...@intel.com>
---

 socfpga.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/fpga/socfpga.c
+++ b/drivers/staging/fpga/socfpga.c
@@ -645,7 +645,7 @@ static int socfpga_fpga_probe(struct pla
        res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
        priv->fpga_data_addr = devm_ioremap_resource(dev, res);
        if (IS_ERR(priv->fpga_data_addr))
-               return PTR_ERR(priv->fpga_base_addr);
+               return PTR_ERR(priv->fpga_data_addr);
 
        priv->irq = platform_get_irq(pdev, 0);
        if (priv->irq < 0)
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to