On Wed, Dec 03, 2014 at 09:17:04AM +0100, Krzysztof Adamski wrote:
> This patch fixes checkpatch complains about lines over 80 characters.
>
> No code was modified, only whitespace changes and comments editing.
>
> Signed-off-by: Krzysztof Adamski <k...@japko.eu>
> ---
> drivers/staging/dgnc/dgnc_cls.h | 24 ++---
> drivers/staging/dgnc/dgnc_driver.c | 50 +++++----
> drivers/staging/dgnc/dgnc_driver.h | 55 +++++-----
> drivers/staging/dgnc/dgnc_mgmt.c | 3 +-
> drivers/staging/dgnc/dgnc_neo.c | 203
> +++++++++++++++++++++++++------------
> drivers/staging/dgnc/dgnc_neo.h | 54 +++++-----
> drivers/staging/dgnc/dgnc_sysfs.c | 129 ++++++++++++-----------
> 7 files changed, 311 insertions(+), 207 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h
> index 465d79a..cb84c99 100644
> --- a/drivers/staging/dgnc/dgnc_cls.h
> +++ b/drivers/staging/dgnc/dgnc_cls.h
> @@ -36,14 +36,14 @@
> ************************************************************************/
>
> struct cls_uart_struct {
> - u8 txrx; /* WR RHR/THR - Holding Reg */
> - u8 ier; /* WR IER - Interrupt Enable Reg */
> - u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo
> Control Reg */
> - u8 lcr; /* WR LCR - Line Control Reg */
> - u8 mcr; /* WR MCR - Modem Control Reg */
> - u8 lsr; /* WR LSR - Line Status Reg */
> - u8 msr; /* WR MSR - Modem Status Reg */
> - u8 spr; /* WR SPR - Scratch Pad Reg */
> + u8 txrx; /* WR RHR/THR - Holding Reg */
> + u8 ier; /* WR IER - Interrupt Enable Reg */
> + u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
> + u8 lcr; /* WR LCR - Line Control Reg */
> + u8 mcr; /* WR MCR - Modem Control Reg */
> + u8 lsr; /* WR LSR - Line Status Reg */
> + u8 msr; /* WR MSR - Modem Status Reg */
> + u8 spr; /* WR SPR - Scratch Pad Reg */
> };
>
> /* Where to read the interrupt register (8bits) */
> @@ -61,8 +61,8 @@ struct cls_uart_struct {
> #define UART_16654_FCR_RXTRIGGER_56 0x80
> #define UART_16654_FCR_RXTRIGGER_60 0xC0
>
> -#define UART_IIR_CTSRTS 0x20 /* Received CTS/RTS
> change of state */
> -#define UART_IIR_RDI_TIMEOUT 0x0C /* Receiver data TIMEOUT */
> +#define UART_IIR_CTSRTS 0x20 /* Received CTS/RTS change of
> state */
> +#define UART_IIR_RDI_TIMEOUT 0x0C /* Receiver data TIMEOUT */
>
> /*
> * These are the EXTENDED definitions for the Exar 654's Interrupt
> @@ -74,8 +74,8 @@ struct cls_uart_struct {
> #define UART_EXAR654_EFR_RTSDTR 0x40 /* Auto RTS/DTR Flow Control
> Enable */
> #define UART_EXAR654_EFR_CTSDSR 0x80 /* Auto CTS/DSR Flow COntrol
> Enable */
>
> -#define UART_EXAR654_XOFF_DETECT 0x1 /* Indicates whether chip saw an
> incoming XOFF char */
> -#define UART_EXAR654_XON_DETECT 0x2 /* Indicates whether chip saw an
> incoming XON char */
> +#define UART_EXAR654_XOFF_DETECT 0x1 /* Chip saw an incoming XOFF char
> */
> +#define UART_EXAR654_XON_DETECT 0x2 /* Chip saw an incoming XON char */
>
> #define UART_EXAR654_IER_XOFF 0x20 /* Xoff Interrupt Enable */
> #define UART_EXAR654_IER_RTSDTR 0x40 /* Output Interrupt Enable */
> diff --git a/drivers/staging/dgnc/dgnc_driver.c
> b/drivers/staging/dgnc/dgnc_driver.c
> index ba98ff3..a2120cf 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -54,14 +54,14 @@ MODULE_SUPPORTED_DEVICE("dgnc");
> * protos for this file
> *
> */
> -static int dgnc_start(void);
> -static int dgnc_finalize_board_init(struct dgnc_board *brd);
> -static void dgnc_init_globals(void);
> -static int dgnc_found_board(struct pci_dev *pdev, int id);
> -static void dgnc_cleanup_board(struct dgnc_board *brd);
> -static void dgnc_poll_handler(ulong dummy);
> -static int dgnc_init_one(struct pci_dev *pdev, const struct
> pci_device_id *ent);
> -static void dgnc_do_remap(struct dgnc_board *brd);
> +static int dgnc_start(void);
> +static int dgnc_finalize_board_init(struct dgnc_board *brd);
> +static void dgnc_init_globals(void);
> +static int dgnc_found_board(struct pci_dev *pdev, int id);
> +static void dgnc_cleanup_board(struct dgnc_board *brd);
> +static void dgnc_poll_handler(ulong dummy);
> +static int dgnc_init_one(struct pci_dev *pdev, const struct pci_device_id
> *ent);
> +static void dgnc_do_remap(struct dgnc_board *brd);
>
> /*
> * File operations permitted on Control/Management major.
> @@ -92,17 +92,17 @@ static struct class *dgnc_class;
> * Poller stuff
> */
> static DEFINE_SPINLOCK(dgnc_poll_lock); /* Poll scheduling lock */
> -static ulong dgnc_poll_time; /* Time of next
> poll */
> -static uint dgnc_poll_stop; /* Used to tell
> poller to stop */
> +static ulong dgnc_poll_time; /* Time of next poll */
> +static uint dgnc_poll_stop; /* Used to tell poller to stop */
> static struct timer_list dgnc_poll_timer;
>
>
> static struct pci_device_id dgnc_pci_tbl[] = {
> - { DIGI_VID, PCI_DEVICE_CLASSIC_4_DID, PCI_ANY_ID, PCI_ANY_ID, 0,
> 0, 0 },
> - { DIGI_VID, PCI_DEVICE_CLASSIC_4_422_DID, PCI_ANY_ID, PCI_ANY_ID,
> 0, 0, 1 },
> - { DIGI_VID, PCI_DEVICE_CLASSIC_8_DID, PCI_ANY_ID, PCI_ANY_ID, 0,
> 0, 2 },
> - { DIGI_VID, PCI_DEVICE_CLASSIC_8_422_DID, PCI_ANY_ID, PCI_ANY_ID,
> 0, 0, 3 },
> - {0,} /* 0 terminated list. */
> +{DIGI_VID, PCI_DEVICE_CLASSIC_4_DID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
> +{DIGI_VID, PCI_DEVICE_CLASSIC_4_422_DID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> +{DIGI_VID, PCI_DEVICE_CLASSIC_8_DID, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 2 },
> +{DIGI_VID, PCI_DEVICE_CLASSIC_8_422_DID, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> 3},
> +{0,} /* 0 terminated list. */
> };
That doesn't look like a good change, does it? Why not use PCI_DEVICE()
macro instead?
thanks,
greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
