On Wed, Dec 03, 2014 at 01:53:18PM +0000, Sean Cleator wrote: > A patch to the slicoss.c file to fix some of the long line issues found by the > checkpath.pl tool > > Signed-off-by: Sean Cleator <seanclea...@hotmail.co.uk> > > --- > drivers/staging/slicoss/slicoss.c | 39 > ++++++++++++++++++++++++++------------- > 1 file changed, 26 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/slicoss/slicoss.c > b/drivers/staging/slicoss/slicoss.c > index 56ca3b6..4df4a7e 100644 > --- a/drivers/staging/slicoss/slicoss.c > +++ b/drivers/staging/slicoss/slicoss.c > @@ -498,12 +498,14 @@ static int slic_card_download(struct adapter *adapter) > slic_reg32_write(&slic_regs->slic_wcs, > baseaddress + codeaddr, FLUSH); > /* Write out instruction to low addr */ > - slic_reg32_write(&slic_regs->slic_wcs, instruction, > FLUSH); > + slic_reg32_write(&slic_regs->slic_wcs, > + instruction, FLUSH); > instruction = *(u32 *)(fw->data + index); > index += 4; > > /* Write out instruction to high addr */ > - slic_reg32_write(&slic_regs->slic_wcs, instruction, > FLUSH); > + slic_reg32_write(&slic_regs->slic_wcs, > + instruction, FLUSH); > instruction = *(u32 *)(fw->data + index); > index += 4; > } > @@ -1533,14 +1535,18 @@ retry_rcvqfill: > dev_err(dev, "%s: LOW 32bits PHYSICAL ADDRESS > == 0\n", > __func__); > dev_err(dev, "skb[%p] PROBLEM\n", skb); > - dev_err(dev, " skbdata[%p]\n", > skb->data); > + dev_err(dev, " skbdata[%p]\n", > + skb->data); > dev_err(dev, " skblen[%x]\n", skb->len); > dev_err(dev, " paddr[%p]\n", paddr); > dev_err(dev, " paddrl[%x]\n", paddrl); > dev_err(dev, " paddrh[%x]\n", paddrh); > - dev_err(dev, " rcvq->head[%p]\n", > rcvq->head); > - dev_err(dev, " rcvq->tail[%p]\n", > rcvq->tail); > - dev_err(dev, " rcvq->count[%x]\n", > rcvq->count); > + dev_err(dev, " rcvq->head[%p]\n", > + rcvq->head); > + dev_err(dev, " rcvq->tail[%p]\n", > + rcvq->tail); > + dev_err(dev, " rcvq->count[%x]\n", > + rcvq->count); > dev_err(dev, "SKIP THIS SKB!!!!!!!!\n"); > goto retry_rcvqfill; > }
This change makes the code look worse, don't you think? Please don't do that. thanks, greg k-h _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
