On Thu, 2015-01-22 at 15:30 +0800, micky_ch...@realsil.com.cn wrote:
> update card drive settings, This setting can be used for rts5249
> rts524A and rts525A.
[]
> diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c

> @@ -36,16 +36,16 @@ static u8 rts5249_get_ic_version(struct rtsx_pcr *pcr)
>  static void rts5249_fill_driving(struct rtsx_pcr *pcr, u8 voltage)
>  {
>       u8 driving_3v3[4][3] = {

It'd be nice to make these arrays static const

> -             {0x11, 0x11, 0x11},
> +             {0x11, 0x11, 0x18},
>               {0x55, 0x55, 0x5C},
> -             {0x99, 0x99, 0x92},
> -             {0x99, 0x99, 0x92},
> +             {0xFF, 0xFF, 0xFF},
> +             {0x96, 0x96, 0x96},
>       };
>       u8 driving_1v8[4][3] = {
> +             {0xC4, 0xC4, 0xC4},
>               {0x3C, 0x3C, 0x3C},
> -             {0xB3, 0xB3, 0xB3},
>               {0xFE, 0xFE, 0xFE},
> -             {0xC4, 0xC4, 0xC4},
> +             {0xB3, 0xB3, 0xB3},
>       };
>       u8 (*driving)[3], drive_sel;


_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to