On Sat, Jan 17, 2015 at 10:39:53PM +1100, Zachary Warren wrote: > Avoids the following warnings from sparse: > visorchannel_funcs.c:457:9: warning: > context imbalance in 'visorchannel_signalremove' - different lock contexts > for basic block > visorchannel_funcs.c:512:9: warning: > context imbalance in 'visorchannel_signalinsert' - different lock contexts > for basic > > These warnings are false positives. Sparse can't track conditional contexts. > The change > puts the lock/unlock into the same context by splitting the insert/remove > functions each > into a wrapper function that does locking if necessary and an inner function > that does the > insert/remove operation. > > Signed-off-by: Zachary Warren <conflatule...@gmail.com> > --- > Diff generated against next-20150116. > > Change from v1: > - Replace the link in the changelog with words. > > .../unisys/visorchannel/visorchannel_funcs.c | 103 > +++++++++++---------- > 1 file changed, 54 insertions(+), 49 deletions(-)
Benjamin, I need an ack from you before I can take this. thanks, greg k-h _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
