Hi,
On Wed, Jan 28, 2015 at 10:38:07PM +0100, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> Instead use the struct variable of the same name.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
> ---
> drivers/staging/xgifb/XGI_main_26.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/xgifb/XGI_main_26.c
> b/drivers/staging/xgifb/XGI_main_26.c
> index 709d49e..ecfdf34 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -1233,7 +1233,7 @@ static int XGIfb_check_var(struct fb_var_screeninfo
> *var, struct fb_info *info)
> unsigned int vtotal = 0;
> unsigned int drate = 0, hrate = 0;
> int found_mode = 0;
> - int refresh_rate, search_idx;
> + int search_idx;
>
> if ((var->vmode & FB_VMODE_MASK) == FB_VMODE_NONINTERLACED) {
> vtotal = var->upper_margin + var->yres + var->lower_margin
> @@ -1271,7 +1271,7 @@ static int XGIfb_check_var(struct fb_var_screeninfo
> *var, struct fb_info *info)
>
> /* Calculation wrong for 1024x600 - force it to 60Hz */
> if ((var->xres == 1024) && (var->yres == 600))
> - refresh_rate = 60;
> + xgifb_info->refresh_rate = 60;
You are changing behaviour here. Did you test it, is it fixing something?
Otherwise you could just delete the whole if block...
A.
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
