On Tue, Feb 17, 2015 at 03:11:38AM +0100, Salah Triki wrote:
> This fixes the following checkpatch.pl warnings:
> WARNING: printk() should include KERN_ facility level
>
> Signed-off-by: Salah Triki <salah.tr...@acm.org>
> ---
> drivers/staging/dgnc/dgnc_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.c
> b/drivers/staging/dgnc/dgnc_driver.c
> index f177d3a..0a05ed2 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -364,7 +364,7 @@ static void dgnc_cleanup_board(struct dgnc_board *brd)
>
> spin_lock_irqsave(&dgnc_global_lock, flags);
> brd->msgbuf = NULL;
> - printk("%s", brd->msgbuf_head);
> + dev_dbg(&brd->pdev->dev, brd->msgbuf_head);
Why did you drop the "%s" portion of this? It's a really bad idea to
allow random structures to be printed in the log, so much so it's
considered a security hole.
So I can't take this as-is, sorry.
greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
