On Tue, 2015-03-10 at 23:53 +0100, Mateusz Kulikowski wrote:
> - Replaced printk() with netdev_*()
trivia:
> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c
> b/drivers/staging/rtl8192e/rtllib_wx.c
[]
> @@ -423,11 +421,8 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
> NULL, (*crypt)->priv);
> if (len == 0) {
> /* Set a default key of all 0 */
> - printk(KERN_INFO "Setting key %d to all zero.\n",
> - key);
> -
> - RTLLIB_DEBUG_WX("Setting key %d to all zero.\n",
> - key);
> + netdev_info(dev, "Setting key %d to all zero.\n", key);
> + RTLLIB_DEBUG_WX("Setting key %d to all zero.\n", key);
This isn't something you've created but it
seems more than a bit nonsensical to emit the
same message at different logging levels.
and below....
> @@ -610,7 +605,7 @@ int rtllib_wx_set_encode_ext(struct rtllib_device *ieee,
> if (ops == NULL) {
> RTLLIB_DEBUG_WX("%s: unknown crypto alg %d\n",
> dev->name, ext->alg);
> - printk(KERN_INFO "========>unknown crypto alg %d\n", ext->alg);
> + netdev_info(dev, "========>unknown crypto alg %d\n", ext->alg);
> ret = -EINVAL;
> goto done;
> }
> @@ -642,7 +637,7 @@ int rtllib_wx_set_encode_ext(struct rtllib_device *ieee,
> (*crypt)->ops->set_key(ext->key, ext->key_len, ext->rx_seq,
> (*crypt)->priv) < 0) {
> RTLLIB_DEBUG_WX("%s: key setting failed\n", dev->name);
> - printk(KERN_INFO "key setting failed\n");
> + netdev_info(dev, "key setting failed\n");
> ret = -EINVAL;
> goto done;
> }
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
