On Mon, 2015-03-16 at 22:57 +0100, Mateusz Kulikowski wrote: > On 13.03.2015 01:27, Joe Perches wrote: > > > > Another thing you might consider is to change these > > embedded function names in another patch to use > > "%s: ", __func__ > > > > RT_TRACE(COMP_ERR, > > "%s: "unknown hardware version\n", > > __func__) > > > > There's a cocci script for that. > > http://cocci.systeme.lip6.narkive.com/nKXf6Bmy/finding-embedded-function-names > > This tool (coccinelle) looks great - I will once take look at it and do swap > like suggested; > It probably can be used to cleanup other parts of this driver as well - if I > knew about it earlier it would save me a lot of repetitive work.
Coccinelle is a very useful tool. Another thing that can save typing is using scripts/checkpatch.pl with the --fix (or --fix-inplace) option with various --types=<foo>. There is a trivial script that can help https://lkml.org/lkml/2014/7/11/794 _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
