On 05/06/2015 08:15 AM, Dan Carpenter wrote:
Also there were some unrelated changes. Benjamin, you should have complained about those when the patch was first sent. That's like the most obvious thing to check when you're reviewing patches.
I'm sorry, I don't understand what part of this is unrelated? To me it looked like Prarit was refactoring the function and its subroutines, mostly the error handling but also cleanup. I've sent similar patches in the past that were refactoring patches, and the patch does what it says in the description, so I thought it was okay.
-- Ben _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
