On Tue, May 26, 2015 at 02:17:46PM +0200, Jason A. Donenfeld wrote:
> +                     data_len = elt->length -
>                                       sizeof(struct oz_get_desc_rsp) + 1;

This was in the original code, but I wonder where the + 1 comes from.
Does anyone know?

To be honest, I would prefer if we just checked:

        if (elt->length < sizeof(struct oz_get_desc_rsp) + 1)
                return;
        data_len = elt->length - sizeof(struct oz_get_desc_rsp) + 1;

Shouldn't there be an upper bound on length?  Shigekatsu?

regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to