On Thu, Jun 25, 2015 at 03:36:46PM -0700, Daniel Grimshaw wrote: > I am a high school student trying to become familiar with linux kernel > development. This is my first patch. > > checkpatch.pl throws a warning that config WIMAX_GDM72XX_QOS, config > WIMAX_GDM72XX_K_MODE, and config WIMAX_GDM72XX_USB do not have enough > of a description. By splitting the current description into multiple > lines, the warning is removed. > > The module still worked with these changes when tested. > > Signed-off-by: Daniel Grimshaw <grims...@linux.vnet.ibm.com> >
Hello Daniel, Nice to see people submitting their first patch. Welcome :) Besides what Dan Carpenter said, I wanted to add a comment about how to send patches. Normally maintainers don't accept patches as attachments. You want to send the patch inline. I recommend these two resources to learn how: http://kernelnewbies.org/FirstKernelPatch Greg's talk "Write and Submit your first Linux kernel Patch" - https://www.youtube.com/watch?v=LLBrBBImJt4 There is a bit of a learning curve. It is normal to not get it right the first time. Feel free to email me directly with any further questions about this. Happy hacking, Luis _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
