On Mon, Aug 17, 2015 at 01:59:44PM -0400, Raphaël Beamonte wrote:
> 2015-08-17 13:47 GMT-04:00 Dan Carpenter <dan.carpen...@oracle.com>:
> >> - printk("[Sendconfigpkt]Get Timed out\n");
> >> + pr_debug("[Sendconfigpkt]Get Timed out\n");
> >
> >
> > Possibly pr_err()?
>
> Yep. My mistake. I'll do the same for Set Timed Out also!
>
> >> - printk("DBG [%s: %d]", __func__, __LINE__); \
> >> - printk(__VA_ARGS__); \
> >> + pr_debug("DBG [%s: %d]", __func__, __LINE__); \
> >> + pr_debug(__VA_ARGS__); \
> >
> > This is a behavior change, I think. pr_debug() needs to be turned on?
>
> Yes... I didn't pay attention to that! pr_debug needs -DDEBUG in the makefile.
> Should I use pr_info here? Or just acknowledge the behavior change for
> the moment,
> as the next aim is probably, as you said, to remove all the local
> debug code? (it is
> actually part of the TODO of this driver... So I could just work on that
> next.)
I would probably just do the rest and leave this part as-is since you're
planning to redo it all anyway. I guess just do stuff which is obvious
and hopefully more and more stuff will become obvious as you go along.
This is a lazy answer but I don't want to think about this driver very
hard... :P
Also always try to order your patches from least controversial to most
controversial. It makes it easier to redo things or sometimes Greg
applies the first part of a patch series.
regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
