[PATCH 1/3] staging: rdma: hfi1: chip: Use setup_timer

[Muhammad Falak R Wani]

Use the timer API function setup_timer instead of init_timer, removing
the structure field assignments.

<smpl>

@timer@
expression e1,e2,e3,fn_ptr;
@@
-init_timer(&e1);
+setup_timer(&e1, fn_ptr, e2);
... when != fn_ptr = e3
-e1.function = fn_ptr;
-e1.data = e2;

</smpl>

Signed-off-by: Muhammad Falak R Wani <falakre...@gmail.com>
---
v2 changes
        -> change subject line to be more specific

mfrw

 drivers/staging/rdma/hfi1/chip.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c
index 46ebc38..c403957 100644
--- a/drivers/staging/rdma/hfi1/chip.c
+++ b/drivers/staging/rdma/hfi1/chip.c
@@ -2215,9 +2215,7 @@ static void update_rcverr_timer(unsigned long opaque)
 
 static int init_rcverr(struct hfi1_devdata *dd)
 {
-       init_timer(&dd->rcverr_timer);
-       dd->rcverr_timer.function = update_rcverr_timer;
-       dd->rcverr_timer.data = (unsigned long) dd;
+       setup_timer(&dd->rcverr_timer, update_rcverr_timer, (unsigned long)dd);
        /* Assume the hardware counter has been reset */
        dd->rcv_ovfl_cnt = 0;
        return mod_timer(&dd->rcverr_timer, jiffies + HZ * RCVERR_CHECK_TIME);
@@ -8156,9 +8154,8 @@ static int init_cntrs(struct hfi1_devdata *dd)
        struct hfi1_pportdata *ppd;
 
        /* set up the stats timer; the add_timer is done at the end */
-       init_timer(&dd->synth_stats_timer);
-       dd->synth_stats_timer.function = update_synth_timer;
-       dd->synth_stats_timer.data = (unsigned long) dd;
+       setup_timer(&dd->synth_stats_timer, update_synth_timer,
+                   (unsigned long)dd);
 
        /***********************/
        /* per device counters */
-- 
1.9.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel