> -----Original Message----- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Sunday, October 25, 2015 7:13 PM > To: Pan Lijun-B44306 <lijun....@freescale.com> > Cc: a...@arndb.de; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; Yoder Stuart-B08248 <stuart.yo...@freescale.com>; > katz Itai-RM05202 <itai.k...@freescale.com>; Rivera Jose-B46482 > <german.riv...@freescale.com>; Li Yang-Leo-R58472 <le...@freescale.com>; > Wood Scott-B07421 <scottw...@freescale.com>; ag...@suse.de; Hamciuc > Bogdan-BHAMCIU1 <bhamc...@freescale.com>; Marginean Alexandru-R89243 > <r89...@freescale.com>; Sharma Bhupesh-B45370 > <bhupesh.sha...@freescale.com>; Erez Nir-RM30794 > <nir.e...@freescale.com>; Schmitt Richard-B43082 > <richard.schm...@freescale.com>; dan.carpen...@oracle.com > Subject: Re: [PATCH 2/5] staging: fsl-mc: define a macro to differentiate root > dprc > > On Sun, Oct 25, 2015 at 05:41:20PM -0500, Lijun Pan wrote: > > Define is_root_dprc(dev) to tell whether a device is root dprc or not > > via platform_bus_type. > > > > Signed-off-by: Lijun Pan <lijun....@freescale.com> > > --- > > drivers/staging/fsl-mc/include/mc.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/staging/fsl-mc/include/mc.h > > b/drivers/staging/fsl-mc/include/mc.h > > index a933291..483763e 100644 > > --- a/drivers/staging/fsl-mc/include/mc.h > > +++ b/drivers/staging/fsl-mc/include/mc.h > > @@ -14,6 +14,7 @@ > > #include <linux/device.h> > > #include <linux/mod_devicetable.h> > > #include <linux/list.h> > > +#include <linux/platform_device.h> > > #include "../include/dprc.h" > > > > #define FSL_MC_VENDOR_FREESCALE 0x1957 > > @@ -109,6 +110,15 @@ struct fsl_mc_resource { > > #define FSL_MC_IS_DPRC 0x0001 > > > > /** > > + * root dprc's parent is a platform device > > + * that platform device's bus type is platform_bus_type. > > + */ > > +#define is_root_dprc(dev) \ > > + ((to_fsl_mc_device(dev)->flags & FSL_MC_IS_DPRC) && \ > > + ((dev)->bus == &fsl_mc_bus_type) && \ > > + ((dev)->parent->bus == &platform_bus_type)) > > + > > It's best to make this type of thing a static inline function, to ensure you > get the > correct typechecking. >
I will take your suggestion and make changes in patch v2. Lijun > thanks, > > greg k-h _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
