This patch replaces kmalloc followed by memcpy with kmemdup.
It is also added error checking of kmemdup.
Signed-off-by: Chaehyun Lim <chaehyun....@gmail.com>
---
drivers/staging/wilc1000/host_interface.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index f7dc61b..50362c4 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3177,8 +3177,10 @@ int host_int_add_wep_key_bss_sta(struct host_if_drv
*hif_drv,
msg.body.key_info.type = WEP;
msg.body.key_info.action = ADDKEY;
msg.drv = hif_drv;
- msg.body.key_info.attr.wep.key = kmalloc(len, GFP_KERNEL);
- memcpy(msg.body.key_info.attr.wep.key, key, len);
+ msg.body.key_info.attr.wep.key = kmemdup(key, len, GFP_KERNEL);
+ if (!msg.body.key_info.attr.wep.key)
+ return -ENOMEM;
+
msg.body.key_info.attr.wep.key_len = len;
msg.body.key_info.attr.wep.index = index;
--
2.6.1
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
