On 12/12/15 17:09, Moritz König wrote:
This patch fixes the format of comments in plx9080.h.

Signed-off-by: Moritz König <moritz.koe...@fau.de>
Signed-off-by: Fabian Lang <fabian.l...@fau.de>
---
  drivers/staging/comedi/drivers/plx9080.h | 132 ++++++++++++++++++++++---------
  1 file changed, 95 insertions(+), 37 deletions(-)

diff --git a/drivers/staging/comedi/drivers/plx9080.h 
b/drivers/staging/comedi/drivers/plx9080.h
index 2570653..40514f7 100644
--- a/drivers/staging/comedi/drivers/plx9080.h
+++ b/drivers/staging/comedi/drivers/plx9080.h
@@ -34,7 +34,8 @@ struct plx_dma_desc {
        /* transfer_size is in bytes, only first 23 bits of register are used */
        __le32 transfer_size;
        /* address of next descriptor (quad word aligned), plus some
-        * additional bits (see PLX_DMA0_DESCRIPTOR_REG) */
+        * additional bits (see PLX_DMA0_DESCRIPTOR_REG)
+        */
        __le32 next;

We prefer the usual block comment style:

        /*
         * Like
         * this
         */

  };

@@ -46,23 +47,38 @@ struct plx_dma_desc {
  **
  **********************************************************************/

-#define PLX_LAS0RNG_REG         0x0000 /* L, Local Addr Space 0 Range Register 
*/
-#define PLX_LAS1RNG_REG         0x00f0 /* L, Local Addr Space 1 Range Register 
*/
+#define PLX_LAS0RNG_REG         0x0000 /* L, Local Addr Space 0 Range
+                                        * Register
+                                        */
+#define PLX_LAS1RNG_REG         0x00f0 /* L, Local Addr Space 1 Range
+                                        * Register
+                                        */

I suggest moving such comments that would wrap over 80 columns onto the previous line, like this:

/* L, Local Addr Space 0 Range Register */
#define PLX_LAS0RNG_REG         0x0000
/* L, Local Addr Space 1 Range Register */
#define PLX_LAS1RNG_REG 0x00f0

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbo...@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to