On 12/01/16 17:33, Spencer E. Olson wrote:
This fixes a bug in function ni_tio_input_inttrig(). The trigger number should be compared to cmd->start_arg, not cmd->start_src.Fixes: 6a760394d7eb ("staging: comedi: ni_tiocmd: clarify the cmd->start_arg validation and use") Cc: <sta...@vger.kernel.org> # 3.17+ Signed-off-by: Spencer E. Olson <olso...@umich.edu> --- Added description suggested by Ian and Dan. Added Fixes:, CC: tags as suggested by Ian. drivers/staging/comedi/drivers/ni_tiocmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
It's okay, except that I don't think you can split the Fixes: line like that. (Maybe you can split it by prefixing the continuation lines with whitespace, but it's easier to grep if it's all on one line, and this is a valid exemption to checkpatch warnings about line lengths in the description.)
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbo...@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=- _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
