> Use setup_timer() for initializing the timer, instead of structure
> assignments.
> This is the preferred/standard way.
> 
> Signed-off-by: Muhammad Falak R Wani <falakre...@gmail.com>

Acked-by: James Simmons <jsimm...@infradead.org>

> ---
>  drivers/staging/lustre/lnet/lnet/net_fault.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c 
> b/drivers/staging/lustre/lnet/lnet/net_fault.c
> index 7d76f28..e4aceb7 100644
> --- a/drivers/staging/lustre/lnet/lnet/net_fault.c
> +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c
> @@ -760,9 +760,7 @@ lnet_delay_rule_add(struct lnet_fault_attr *attr)
>               wait_event(delay_dd.dd_ctl_waitq, delay_dd.dd_running);
>       }
>  
> -     init_timer(&rule->dl_timer);
> -     rule->dl_timer.function = delay_timer_cb;
> -     rule->dl_timer.data = (unsigned long)rule;
> +     setup_timer(&rule->dl_timer, delay_timer_cb, (unsigned long)rule);
>  
>       spin_lock_init(&rule->dl_lock);
>       INIT_LIST_HEAD(&rule->dl_msg_list);
> -- 
> 1.9.1
> 
> _______________________________________________
> lustre-devel mailing list
> lustre-de...@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
> 
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to