[PATCH 1/9] staging: ks7010: Delete unnecessary checks before the function call "kfree"

[SF Markus Elfring]

From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 17 Jul 2016 13:14:57 +0200

The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/staging/ks7010/ks7010_sdio.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c 
b/drivers/staging/ks7010/ks7010_sdio.c
index b7337fd..7da6c84 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -732,8 +732,7 @@ static int ks7010_sdio_update_index(struct ks_wlan_private 
*priv, u32 index)
                goto error_out;
        }
  error_out:
-       if (data_buf)
-               kfree(data_buf);
+       kfree(data_buf);
        return rc;
 }
 
@@ -763,8 +762,7 @@ static int ks7010_sdio_data_compare(struct ks_wlan_private 
*priv, u32 address,
                goto error_out;
        }
  error_out:
-       if (read_buf)
-               kfree(read_buf);
+       kfree(read_buf);
        return rc;
 }
 
@@ -879,8 +877,7 @@ static int ks7010_upload_firmware(struct ks_wlan_private 
*priv,
        release_firmware(fw_entry);
  error_out0:
        sdio_release_host(card->func);
-       if (rom_buf)
-               kfree(rom_buf);
+       kfree(rom_buf);
        return rc;
 }
 
@@ -1199,9 +1196,7 @@ static void ks7010_sdio_remove(struct sdio_func *func)
                unregister_netdev(netdev);
 
                trx_device_exit(priv);
-               if (priv->ks_wlan_hw.read_buf) {
-                       kfree(priv->ks_wlan_hw.read_buf);
-               }
+               kfree(priv->ks_wlan_hw.read_buf);
                free_netdev(priv->net_dev);
                card->priv = NULL;
        }
-- 
2.9.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel