On Fri, Sep 23, 2016 at 11:05:14AM +0300, giannis.dami...@gmail.com wrote:
> From: Yannis Damigos <giannis.dami...@gmail.com>
> 
> This patch fixes the following whitespace issues:
> 
> CHECK: Alignment should match open parenthesis
> +int ion_parse_dt_heap_common(struct device_node *heap_node,
> +                     struct ion_platform_heap *heap,
> 
> CHECK: Alignment should match open parenthesis
> +     pr_info("%s: id %d type %d name %s align %lx\n", __func__,
> +                     heap->id, heap->type, heap->name, heap->align);
> 
> CHECK: Alignment should match open parenthesis
> +int ion_setup_heap_common(struct platform_device *parent,
> +                     struct device_node *heap_node,
> 
> CHECK: Alignment should match open parenthesis
> +struct ion_platform_data *ion_parse_dt(struct platform_device *pdev,
> +                                     struct ion_of_heap *compatible)
> 
> CHECK: Alignment should match open parenthesis
> +     heaps = devm_kzalloc(&pdev->dev,
> +                             sizeof(struct
> ion_platform_heap)*num_heaps,

Why is your changelog text line-wrapped?

> 
> CHECK: spaces preferred around that '*' (ctx:VxV)
> +                             sizeof(struct
> ion_platform_heap)*num_heaps,

Same here.

And don't mix different types of whitespace cleanup in the same patch
please.

thanks,

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to