On Sun, Oct 09, 2016 at 07:58:00PM +0530, Harman Kalra wrote:
> This patch replaces calls to the "printk" with  appropriate "pr_*"
> function thus addressing the following warning generated by the
> checkpatch script:
> 
> Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
>       dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...
> 
> Signed-off-by: Harman Kalra <harman4li...@gmail.com>
> ---
>  drivers/staging/i4l/act2000/act2000_isa.c |   23 ++++++++++-------------
>  1 file changed, 10 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/staging/i4l/act2000/act2000_isa.c 
> b/drivers/staging/i4l/act2000/act2000_isa.c
> index ad7a039..1a91b52 100644
> --- a/drivers/staging/i4l/act2000/act2000_isa.c
> +++ b/drivers/staging/i4l/act2000/act2000_isa.c
> @@ -78,10 +78,10 @@
>       if (istatus & ISA_ISR_ERR) {
>               /* Error Interrupt */
>               istatus &= ISA_ISR_ERR_MASK;
> -             printk(KERN_WARNING "act2000: errIRQ\n");
> +             pr_warn("act2000: errIRQ\n");
>       }
>       if (istatus)
> -             printk(KERN_DEBUG "act2000: ?IRQ %d %02x\n", card->irq, 
> istatus);
> +             pr_warn("act2000: ?IRQ %d %02x\n", card->irq, istatus);

shouldn't that be pr_debug()?
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to