On Tue, Oct 04, 2016 at 10:16:39AM -0400, David Kershner wrote:
> From: Erik Arfvidson <erik.arfvid...@unisys.com>
>
> This patch removes all unused pound defines in controlvmchannel.h.
> Adds a comment on the now unused error codes for our spar firmware
> to avoid new error messages conflicting with previously defined
> messages.
>
> Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com>
> Signed-off-by: David Kershner <david.kersh...@unisys.com>
> ---
> drivers/staging/unisys/visorbus/controlvmchannel.h | 36
> ++--------------------
> 1 file changed, 3 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorbus/controlvmchannel.h
> b/drivers/staging/unisys/visorbus/controlvmchannel.h
> index f0bfc4d..a71f875 100644
> --- a/drivers/staging/unisys/visorbus/controlvmchannel.h
> +++ b/drivers/staging/unisys/visorbus/controlvmchannel.h
> @@ -43,8 +43,6 @@
> ULTRA_CONTROLVM_CHANNEL_PROTOCOL_VERSIONID, \
> ULTRA_CONTROLVM_CHANNEL_PROTOCOL_SIGNATURE)
>
> -#define MAX_SERIAL_NUM 32
> -
> /* Defines for various channel queues */
> #define CONTROLVM_QUEUE_REQUEST 0
> #define CONTROLVM_QUEUE_RESPONSE 1
> @@ -436,26 +434,6 @@ struct spar_controlvm_channel_protocol {
> struct controlvm_message saved_crash_msg[CONTROLVM_CRASHMSG_MAX];
> };
>
> -/* Offsets for VM channel attributes */
> -#define VM_CH_REQ_QUEUE_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, request_queue)
> -#define VM_CH_RESP_QUEUE_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, response_queue)
> -#define VM_CH_EVENT_QUEUE_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, event_queue)
> -#define VM_CH_ACK_QUEUE_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, event_ack_queue)
> -#define VM_CH_REQ_MSG_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, request_msg)
> -#define VM_CH_RESP_MSG_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, response_msg)
> -#define VM_CH_EVENT_MSG_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, event_msg)
> -#define VM_CH_ACK_MSG_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, event_ack_msg)
> -#define VM_CH_CRASH_MSG_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, saved_crash_msg)
> -
> /* The following header will be located at the beginning of PayloadVmOffset
> for
> * various ControlVm commands. The receiver of a ControlVm command with a
> * PayloadVmOffset will dereference this address and then use
> connection_offset,
> @@ -482,6 +460,9 @@ struct spar_controlvm_parameters_header {
> u32 reserved; /* Natural alignment */
> };
>
> +/* The following error messages are reserved 100, 101,
> + * 201, 202, 401, 402, 403
> + */
Reserved where? It's ok to leave defines in here that you don't use, if
the hardware uses/needs them somehow. Don't feel like you have to only
have things that you use, especially if you end up with cryptic comments
like this :)
I'll not take this patch.
thanks,
greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
