Propagate the error up the stack instead of ignoring it.

Signed-off-by: David Kershner <david.kersh...@unisys.com>
Reported-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/staging/unisys/visorbus/visorchipset.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c 
b/drivers/staging/unisys/visorbus/visorchipset.c
index 0c454f6..e081de3 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -561,7 +561,7 @@ struct visor_device *visorbus_get_device_by_id(u32 bus_no, 
u32 dev_no,
                                         CONTROLVM_QUEUE_REQUEST, &outmsg);
 }
 
-static void controlvm_respond_physdev_changestate(
+static int controlvm_respond_physdev_changestate(
                struct controlvm_message_header *msg_hdr, int response,
                struct spar_segment_state state)
 {
@@ -570,10 +570,8 @@ static void controlvm_respond_physdev_changestate(
        controlvm_init_response(&outmsg, msg_hdr, response);
        outmsg.cmd.device_change_state.state = state;
        outmsg.cmd.device_change_state.flags.phys_device = 1;
-       if (visorchannel_signalinsert(controlvm_channel,
-                                     CONTROLVM_QUEUE_REQUEST, &outmsg)) {
-               return;
-       }
+       return visorchannel_signalinsert(controlvm_channel,
+                                        CONTROLVM_QUEUE_REQUEST, &outmsg);
 }
 
 enum crash_obj_type {
-- 
1.9.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to