On Wed, 2017-03-01 at 20:58 +0100, Julia Lawall wrote:
>
> On Thu, 2 Mar 2017, Arushi Singhal wrote:
>
> > Fixed coding style for null comparisons in speakup driver to be more
> > consistant with the rest of the kernel coding style.
And Arushi, please use checkpatch on your proposed
patches before sending them.
$ ./scripts/checkpatch.pl
~/staging-speakup-Comparison-to-NULL-could-be-written.patch --nosummary
WARNING: 'consistant' may be misspelled - perhaps 'consistent'?
#18:
consistant with the rest of the kernel coding style.
CHECK: Avoid CamelCase: <CT_Off>
#138: FILE: drivers/staging/speakup/main.c:1512:
+ if (!synth || up_flag || spk_shut_up || cursor_track == CT_Off) {
ERROR: space prohibited before that close parenthesis ')'
#147: FILE: drivers/staging/speakup/main.c:1708:
+ if (spk_shut_up || !synth ) {
ERROR: space prohibited before that close parenthesis ')'
#156: FILE: drivers/staging/speakup/main.c:1725:
+ if ((vc->vc_num != fg_console) || spk_shut_up || !synth )
ERROR: space prohibited before that close parenthesis ')'
#183: FILE: drivers/staging/speakup/main.c:1813:
+ if (!p_header )
ERROR: space prohibited before that close parenthesis ')'
#210: FILE: drivers/staging/speakup/main.c:2068:
+ if (!synth )
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
