On Tue, Mar 07, 2017 at 05:33:07PM +1100, Tobin C. Harding wrote:
> +     /* Only allow 1 open at a time on mgmt device */
> +     if (dgnc_mgmt_in_use[minor]) {
> +             rc = -EBUSY;
> +             goto out;
> +     }
> +     dgnc_mgmt_in_use[minor]++;
>  
> +out:

Better to use "unlock" instead of "out".  "out" is very ambigous.

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to