Previous work was done auditing return statements and use of goto statements in drivers/staging/dgnc however some mistakes were made. Review picked up the mistakes but due to developer omission patch set was merged.
Make changes do dgnc inline with previous review suggestions. Patch 01 change return statements to return error code directly. Patch 02 fix checkpatch whitespace CHECK and make dgnc return statements uniform. Patch 03 remove unnecessary return value cast. Series has not been tested. staging-next branch with series applied has been checked with Smatch, checkpatch --strict, and Sparse. Series does not introduce any new warnings/errors. Each patch in series has been applied and built on x86_64 and on PowerPC. Tobin C. Harding (3): staging: dgnc: return error code directly staging: dgnc: fix whitespace before return staging: dgnc: remove explicit cast drivers/staging/dgnc/dgnc_driver.c | 6 ++- drivers/staging/dgnc/dgnc_mgmt.c | 3 +- drivers/staging/dgnc/dgnc_tty.c | 79 +++++++++++++++++++------------------- 3 files changed, 47 insertions(+), 41 deletions(-) -- 2.7.4 _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
