This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@

-1 << c
+BIT(c)

Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
 drivers/staging/octeon/ethernet-tx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/octeon/ethernet-tx.c 
b/drivers/staging/octeon/ethernet-tx.c
index ff4119e8de42..f00186ac4e27 100644
--- a/drivers/staging/octeon/ethernet-tx.c
+++ b/drivers/staging/octeon/ethernet-tx.c
@@ -381,7 +381,7 @@ int cvm_oct_xmit(struct sk_buff *skb, struct net_device 
*dev)
            (ip_hdr(skb)->version == 4) &&
            (ip_hdr(skb)->ihl == 5) &&
            ((ip_hdr(skb)->frag_off == 0) ||
-            (ip_hdr(skb)->frag_off == htons(1 << 14))) &&
+            (ip_hdr(skb)->frag_off == htons(BIT(14)))) &&
            ((ip_hdr(skb)->protocol == IPPROTO_TCP) ||
             (ip_hdr(skb)->protocol == IPPROTO_UDP))) {
                /* Use hardware checksum calc */
@@ -613,7 +613,7 @@ int cvm_oct_xmit_pow(struct sk_buff *skb, struct net_device 
*dev)
 #endif
                work->word2.s.is_frag = !((ip_hdr(skb)->frag_off == 0) ||
                                          (ip_hdr(skb)->frag_off ==
-                                             1 << 14));
+                                             BIT(14)));
 #if 0
                /* Assume Linux is sending a good packet */
                work->word2.s.IP_exc = 0;
-- 
2.11.0

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to