On Sat, 2017-04-01 at 04:46 +0100, Al Viro wrote: > On Fri, Mar 31, 2017 at 08:36:22PM -0700, Joe Perches wrote: > > On Sat, 2017-04-01 at 04:32 +0100, Al Viro wrote: > > > On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote: > > > > Replace string with formatted arguments in the dev_warn() call. It > > > > removes > > > > the checkpatch warning: > > > > > > > > WARNING: Prefer using "%s", __func__ to embedded function names > > > > [] > > > Again, checkpatch warning is badly written > > > > In your opinion, what wording would be better? > > MILD SUGGESTION: don't spell the function name out in format strings; > "this_function: foo is %d", n > might be better off as > "%s: foo is %d", __func__, n > in case you ever move it to another function or rename your function.
Thank you sir, may I have another. checkpatch messages are single line. _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
