There were two instances for vmbus_sendpacket_pagebuffer_ctl
and vmbus_sendpacket_pagebuffer. Go with simpler name and get
rid of wrapper.

Signed-off-by: Stephen Hemminger <sthem...@microsoft.com>
---
 drivers/hv/channel.c        | 28 +++++-----------------------
 drivers/net/hyperv/netvsc.c | 14 +++++++-------
 include/linux/hyperv.h      | 19 ++++++-------------
 3 files changed, 18 insertions(+), 43 deletions(-)

diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index bf3c2e496a5c..ae8c2f3a4a1a 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -673,16 +673,16 @@ int vmbus_sendpacket(struct vmbus_channel *channel, void 
*buffer,
 EXPORT_SYMBOL(vmbus_sendpacket);
 
 /*
- * vmbus_sendpacket_pagebuffer_ctl - Send a range of single-page buffer
+ * vmbus_sendpacket_pagebuffer - Send a range of single-page buffer
  * packets using a GPADL Direct packet type. This interface allows you
  * to control notifying the host. This will be useful for sending
  * batched data. Also the sender can control the send flags
  * explicitly.
  */
-int vmbus_sendpacket_pagebuffer_ctl(struct vmbus_channel *channel,
-                                   struct hv_page_buffer pagebuffers[],
-                                   u32 pagecount, void *buffer, u32 bufferlen,
-                                   u64 requestid, u32 flags)
+int vmbus_sendpacket_pagebuffer(struct vmbus_channel *channel,
+                               const struct hv_page_buffer pagebuffers[],
+                               u32 pagecount, void *buffer, u32 bufferlen,
+                               u64 requestid, u32 flags)
 {
        int i;
        struct vmbus_channel_packet_page_buffer desc;
@@ -728,24 +728,6 @@ int vmbus_sendpacket_pagebuffer_ctl(struct vmbus_channel 
*channel,
 
        return hv_ringbuffer_write(channel, bufferlist, 3);
 }
-EXPORT_SYMBOL_GPL(vmbus_sendpacket_pagebuffer_ctl);
-
-/*
- * vmbus_sendpacket_pagebuffer - Send a range of single-page buffer
- * packets using a GPADL Direct packet type.
- */
-int vmbus_sendpacket_pagebuffer(struct vmbus_channel *channel,
-                                    struct hv_page_buffer pagebuffers[],
-                                    u32 pagecount, void *buffer, u32 bufferlen,
-                                    u64 requestid)
-{
-       u32 flags = VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED;
-
-       return vmbus_sendpacket_pagebuffer_ctl(channel, pagebuffers, pagecount,
-                                              buffer, bufferlen,
-                                              requestid, flags);
-
-}
 EXPORT_SYMBOL_GPL(vmbus_sendpacket_pagebuffer);
 
 /*
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index dabf20e77097..b1515a0009b0 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -791,13 +791,13 @@ static inline int netvsc_send_pkt(
        if (packet->page_buf_cnt) {
                pgbuf = packet->cp_partial ? (*pb) +
                        packet->rmsg_pgcnt : (*pb);
-               ret = vmbus_sendpacket_pagebuffer_ctl(out_channel,
-                                                     pgbuf,
-                                                     packet->page_buf_cnt,
-                                                     &nvmsg,
-                                                     sizeof(struct 
nvsp_message),
-                                                     req_id,
-                                                     
VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED);
+               ret = vmbus_sendpacket_pagebuffer(out_channel,
+                                                 pgbuf,
+                                                 packet->page_buf_cnt,
+                                                 &nvmsg,
+                                                 sizeof(struct nvsp_message),
+                                                 req_id,
+                                                 
VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED);
        } else {
                ret = vmbus_sendpacket(out_channel, &nvmsg, sizeof(struct 
nvsp_message),
                                       req_id, VM_PKT_DATA_INBAND,
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 79733df54474..6858e8e92947 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1030,19 +1030,12 @@ extern int vmbus_sendpacket(struct vmbus_channel 
*channel,
                            u32 flags);
 
 extern int vmbus_sendpacket_pagebuffer(struct vmbus_channel *channel,
-                                           struct hv_page_buffer pagebuffers[],
-                                           u32 pagecount,
-                                           void *buffer,
-                                           u32 bufferlen,
-                                           u64 requestid);
-
-extern int vmbus_sendpacket_pagebuffer_ctl(struct vmbus_channel *channel,
-                                          struct hv_page_buffer pagebuffers[],
-                                          u32 pagecount,
-                                          void *buffer,
-                                          u32 bufferlen,
-                                          u64 requestid,
-                                          u32 flags);
+                                      const struct hv_page_buffer 
pagebuffers[],
+                                      u32 pagecount,
+                                      void *buffer,
+                                      u32 bufferlen,
+                                      u64 requestid,
+                                      u32 flags);
 
 extern int vmbus_sendpacket_mpb_desc(struct vmbus_channel *channel,
                                     struct vmbus_packet_mpb_array *mpb,
-- 
2.11.0

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to