Hello Greg,
12.06.2017 13:47, Greg Kroah-Hartman wrote:
On Mon, Jun 12, 2017 at 01:44:09PM +0200, Greg Kroah-Hartman wrote:
On Mon, Jun 12, 2017 at 12:07:41PM +0200, Hans de Goede wrote:
The most important thing is for the driver to be atomic if it's KMS
only, and it would be good to have someone review that properly.
I believe it does not use the atomic APIs atm, so that would be one
of the first things to fix then. Another question is if people
(you and Daniel at least) can live with the non kernel-coding
style shared files under the osindependent dir ?
Why not just spend a few days and fix up all of the kernel-style issues
so it can be a "real" driver? It shouldn't take all that long,
especially for someone with Linux kernel experience (hint, hint...)
The idea was that bits which are device-specific and which there would
be no interest in sharing with other drivers in the kernel could stay in
the VirtualBox coding style. Since most updates to this code are likely
to come from us and it is shared with our drivers for other platforms,
that would make it easier for the in-kernel driver maintainer to pull
fixes from the VirtualBox tree. We tried to remove code from
osindependent which would not fit that bill - notably, Hans reworked the
driver to use a kernel gen_pool structure where it was previously using
a VirtualBox-specific heap class. My understanding is that something
similar was considered to be acceptable for the new AMD driver code. Of
course, our code is much simpler than AMD's, so it would not be the end
of the world if it were converted to kernel style, but I see more
disadvantages than advantages to doing it.
Only put stuff in staging for a good reason, and that reason can be "I
don't know how to clean this stuff up", but I don't think that is the
case here...
And why are you cc:ing a mailing list that does not accept non-members
to post? that's just annoying...
Isn't dri-devel members only too? My messages seem to take a while to
show up there, which would be explained by waiting for a moderator,
though I don't get a warning that the message is waiting for approval.
For now we have disabled that on vbox-dev too (I assume that was the
list you meant).
Regards
Michael
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
