> -----Original Message-----
> From: armetallica [mailto:armetall...@gmail.com]
> Sent: Sunday, July 9, 2017 7:58 PM
> To: gre...@linuxfoundation.org
> Cc: *S-Par-Maintainer <sparmaintai...@unisys.com>;
> de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org
> Subject: [PATCH]
> 
> From bb1aac6ae6b21b903d8743712e21aeb1a6b22163 Mon Sep 17 00:00:00
> 2001
> From: Armin Schoenlieb <armetall...@gmail.com>
> Date: Mon, 10 Jul 2017 01:52:41 +0200
> Subject: [PATCH] staging: unisys: visorbus: fix brace coding style issue in
>  visorbus_main.c This is a patch to the visorbus_main.c file that fixes up six
>  brace errors found by the checkpatch.pl tool
> 

Thanks for the patch! It looks like I sent up a patch to Greg that addresses 
this
issue on 6/30/2017:
 
        [PATCH 25/25] staging: unisys: visorbus: fix improper bracket blocks

Also, your patch come in with a subject of just the word [PATCH] and the patch
comment was messed up. I'm not sure how you generated the patch, but you
might want to try it with format-patch and then do a git send-email to yourself
as a dry-run to see if the patch looks OK when you get it.

David Kershner


> Signed-off-by: Armin Schoenlieb <armetall...@gmail.com>
> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index 1c785dd19ddd..c56496269fc8 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -270,7 +270,8 @@ static const struct attribute_group
> *visorbus_channel_groups[] = {
> 
>  static ssize_t partition_handle_show(struct device *dev,
>                                    struct device_attribute *attr,
> -                                  char *buf) {
> +                                  char *buf)
> +{
>       struct visor_device *vdev = to_visor_device(dev);
>       u64 handle = visorchannel_get_clientpartition(vdev->visorchannel);
> 
> @@ -280,7 +281,8 @@ static DEVICE_ATTR_RO(partition_handle);
> 
>  static ssize_t partition_guid_show(struct device *dev,
>                                  struct device_attribute *attr,
> -                                char *buf) {
> +                                char *buf)
> +{
>       struct visor_device *vdev = to_visor_device(dev);
> 
>       return sprintf(buf, "{%pUb}\n", &vdev->partition_uuid);
> @@ -289,7 +291,8 @@ static DEVICE_ATTR_RO(partition_guid);
> 
>  static ssize_t partition_name_show(struct device *dev,
>                                  struct device_attribute *attr,
> -                                char *buf) {
> +                                char *buf)
> +{
>       struct visor_device *vdev = to_visor_device(dev);
> 
>       return sprintf(buf, "%s\n", vdev->name);
> @@ -298,7 +301,8 @@ static DEVICE_ATTR_RO(partition_name);
> 
>  static ssize_t channel_addr_show(struct device *dev,
>                                struct device_attribute *attr,
> -                              char *buf) {
> +                              char *buf)
> +{
>       struct visor_device *vdev = to_visor_device(dev);
>       u64 addr = visorchannel_get_physaddr(vdev->visorchannel);
> 
> @@ -308,7 +312,8 @@ static DEVICE_ATTR_RO(channel_addr);
> 
>  static ssize_t channel_bytes_show(struct device *dev,
>                                 struct device_attribute *attr,
> -                               char *buf) {
> +                               char *buf)
> +{
>       struct visor_device *vdev = to_visor_device(dev);
>       u64 nbytes = visorchannel_get_nbytes(vdev->visorchannel);
> 
> @@ -318,7 +323,8 @@ static DEVICE_ATTR_RO(channel_bytes);
> 
>  static ssize_t channel_id_show(struct device *dev,
>                              struct device_attribute *attr,
> -                            char *buf) {
> +                            char *buf)
> +{
>       struct visor_device *vdev = to_visor_device(dev);
>       int len = 0;
> 
> --
> 2.11.0

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
  • [PATCH] armetallica
    • [PATCH] armetallica
      • RE: [PATCH] Kershner, David A

Reply via email to