Fix your email From header to match your Signed-off-by line. The
subject should be:
[PATCH] staging: wlan-ng: Correct multiple line dereference
On Fri, Jul 28, 2017 at 03:33:27PM +0530, janani-sankarababu wrote:
> This patch fixes multiple line dereference Warning reported by checkpath
> script. This has been made to simplify the code and make it more readable.
Break this line up at the 70 character mark.
>
> Signed-off-by: Janani S <janani...@gmail.com>
Use your full legal name as if you were signing a legal document to
certify that you haven't stolen this code from Darl McBride.
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
> b/drivers/staging/wlan-ng/hfa384x_usb.c
> index ee5fa86..2fc5f3e 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -1345,15 +1345,13 @@ static int hfa384x_usbctlx_complete_sync(struct
> hfa384x *hw,
> kfree(ctlx);
> } else if (mode == DOWAIT) {
> struct usbctlx_cmd_completor completor;
> + struct usbctlx_completor *cmplt;
> +
> + cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
> + &cmd->result);
>
> result =
> - hfa384x_usbctlx_complete_sync(hw, ctlx,
> - init_cmd_completor(&completor,
> - &ctlx->
> - inbuf.
> - cmdresp,
> - &cmd->
> - result));
> + hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
Move this to the previous line:
result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
Also the patch got corrupted by your email client so it can't apply.
Read Documentation/process/email-clients.rst
But generally this is a nice little cleanup. Please resend a v2
version.
regards,
dan carpenter
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
