Do the check with the values in the structure instead of copying them to
local variables.

Reviewed-by: Sameer Wadgaonkar <sameer.wadgaon...@unisys.com>
Signed-off-by: David Kershner <david.kersh...@unisys.com>
Reviewed-by: Tim Sell <timothy.s...@unisys.com>
---
 drivers/staging/unisys/visorbus/visorchipset.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c 
b/drivers/staging/unisys/visorbus/visorchipset.c
index 7047989..962fd97 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -364,11 +364,9 @@ static int match_visorbus_dev_by_id(struct device *dev, 
void *data)
 {
        struct visor_device *vdev = to_visor_device(dev);
        struct visor_busdev *id = data;
-       u32 bus_no = id->bus_no;
-       u32 dev_no = id->dev_no;
 
-       if ((vdev->chipset_bus_no == bus_no) &&
-           (vdev->chipset_dev_no == dev_no))
+       if ((vdev->chipset_bus_no == id->bus_no) &&
+           (vdev->chipset_dev_no == id->dev_no))
                return 1;
 
        return 0;
-- 
git-series 0.9.1
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to